Great.<br><br>I need to correct my statement, the check for _MSC_VER <= 1600<br>was the culprit, like this case:<br><br>#if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__<br>#include <sys/types.h> /* for off_t */<br>
#if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */<br>#ifndef fseeko<br>#define fseeko fseek<br>#ifndef fseeko<br>#define fseeko fseek<br>#endif<br>#endif<br><br>Cheers,<br>Cristian.<br><br><div class="gmail_quote">
On Wed, Mar 6, 2013 at 6:24 PM, Ben Allison <span dir="ltr"><<a href="mailto:benski@winamp.com" target="_blank">benski@winamp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Those checks account for compiler changes/improvements introduced in<br>
Visual Studio 2010 that are not present in Visual Studio 2008.<br>
<br>
I will grab Visual Studio 2012 off of MSDN and make sure everything is OK<br>
there.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Ben<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> Hi Ben,<br>
><br>
> Can you please remove the _MSC_VER >= 1600 check?<br>
><br>
> _MSC_VER 1600 is set for Visual Studio 2010, which means<br>
> that Visual Studio 2012 will get a lot of errors because _MSC_VER<br>
> is defined as 1700.<br>
><br>
> Cheers,<br>
> Cristian.<br>
><br>
> On Wed, Mar 6, 2013 at 5:53 PM, Ben Allison <<a href="mailto:benski@winamp.com">benski@winamp.com</a>> wrote:<br>
><br>
>> Thanks, Erik.<br>
>><br>
>> This is the delta that should fix everything up.<br>
>> I hope that #include "share/compat.h" is acceptable from the<br>
>> test_streams<br>
>> binary. If not, you can probably change it to FLAC/ordinals.h instead<br>
>><br>
>> Also don't forget to commit my earlier VERSION="1.3.0" patch. You can<br>
>> add<br>
>> the "pre1" in a normal text editor without risk. I didn't include those<br>
>> changes in the big patch you committed already.<br>
>> -Ben<br>
>><br>
>> > Ben Allison wrote:<br>
>> ><br>
>> >> Erik, et al.<br>
>> >><br>
>> >> This fixes the entire library and does it more cleanly. It puts most<br>
>> of<br>
>> >> the guts into share/compat.h<br>
>> ><br>
>> > Thanks Ben.<br>
>> ><br>
>> > I applied a slightly tweaked version of the patch. The patch had to be<br>
>> > tweaked because it broke the Linux build :-). Specifically, the file<br>
>> > include/FLAC/ordinals.h is a public header file and should not include<br>
>> > the project internal header "share/compat.h". I also moved some of the<br>
>> > #ifdef stuff to "share/compat.h".<br>
>> ><br>
>> > What is in git now may not build on windows but should be really,<br>
>> really<br>
>> > close. I'd appreciate it if you could test it and report the error<br>
>> > messages. It might take a couple of iterations but we should get it<br>
>> > working for all the platforms.<br>
>> ><br>
>> > Cheers,<br>
>> > Erik<br>
>> > --<br>
>> > ----------------------------------------------------------------------<br>
>> > Erik de Castro Lopo<br>
>> > <a href="http://www.mega-nerd.com/" target="_blank">http://www.mega-nerd.com/</a><br>
>> > _______________________________________________<br>
>> > flac-dev mailing list<br>
>> > <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>
>> > <a href="http://lists.xiph.org/mailman/listinfo/flac-dev" target="_blank">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>
>> ><br>
>><br>
>> _______________________________________________<br>
>> flac-dev mailing list<br>
>> <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>
>> <a href="http://lists.xiph.org/mailman/listinfo/flac-dev" target="_blank">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>
>><br>
>><br>
><br>
<br>
</div></div></blockquote></div><br>