Hi Erik,<div><br></div><div>I must also apologize for the delay.</div><div><br></div><div>Thanks for taking the look at the patches. I'll have to look into why Gentoo has these patches. I mostly just grabbed and forwarded them onto you to help minimize the amount of patches needed for Gentoo's FLAC package.</div>
<div><br></div><div>I'll ask around and see what happens.</div><div><br></div><div>Thanks again.</div><div><br><div class="gmail_quote">On Thu, Jul 26, 2012 at 3:30 PM, Erik de Castro Lopo <span dir="ltr"><<a href="mailto:mle+la@mega-nerd.com" target="_blank">mle+la@mega-nerd.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jaren,<br>
<br>
Sorry for the delat dealing with these patches.<br>
<div class="im"><br>
Jaren Stangret wrote:<br>
<br>
> Below are the patches supplied by Gentoo (merged against MASTER) and with<br>
> the Changelog explanations of them as well as the discussion link<br>
> surrounding the patch:<br>
<br>
</div>Unfortunately the Gentoo changelog explanations are a little lacking<br>
and very Gentoo specific.<br>
<br>
><br>
> *flac-9999-asm.patch:*<br>
> *28 Sep 2007; Samuli Suominen <<a href="mailto:drac@gentoo.org">drac@gentoo.org</a>>*<br>
<div class="im">> +files/flac-1.2.1-asm.patch,<br>
> Fix TEXTRELs using patch from PaX Team from bug 193222 and while at it,<br>
> attempt to clean up ebuild a bit. Revert last commit restoring elibtoolize<br>
> for fbsd since eautoreconf allready does libtoolize.<br>
><br>
</div>> *Gentoo bug where this is discussed:*<br>
> *<a href="https://bugs.gentoo.org/show_bug.cgi?id=193222*" target="_blank">https://bugs.gentoo.org/show_bug.cgi?id=193222*</a><br>
<br>
I followed those links and did some reading and came up with a<br>
commit message that made sense for FLAC.<br>
<br>
> *flac-9999-asneeded.patch*<br>
> *20 Sep 2007; Samuli Suominen <<a href="mailto:drac@gentoo.org">drac@gentoo.org</a>>*<br>
> +files/flac-1.2.1-asneeded.patch,<br>
> Version bump.<br>
><br>
> *There isn't a bug detailing why this patch is here, but I believe it's to<br>
<div class="im">> allow the --as-needed flag to the bfd linker. More information can be<br>
</div>> found here:*<br>
> *<a href="http://www.gentoo.org/proj/en/qa/asneeded.xml*" target="_blank">http://www.gentoo.org/proj/en/qa/asneeded.xml*</a><br>
<br>
I've read all that and I still can't figure out why that patch is<br>
needed.<br>
<br>
> *flac-9999-ogg-m4.patch*<br>
> *28 Mar 2011; Arun Raghavan <<a href="mailto:ford_prefect@gentoo.org">ford_prefect@gentoo.org</a>>*<br>
<div class="im">> +files/flac-1.2.1-ogg-m4.patch:<br>
> Update the shipped version of ogg.m4 so that users of libflac don't get a<br>
> ton of libtool warnings while linking.<br>
<br>
</div>Same for that one.<br>
<br>
I am happy to take patches but I need information about what they do<br>
and why.<br>
<div class="HOEnZb"><div class="h5"><br>
Cheers,<br>
Erik<br>
--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="http://www.mega-nerd.com/" target="_blank">http://www.mega-nerd.com/</a><br>
_______________________________________________<br>
flac-dev mailing list<br>
<a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>
<a href="http://lists.xiph.org/mailman/listinfo/flac-dev" target="_blank">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Jaren Stangret<br>Computer Science<br>Engineering/Mathematics<br>University Of Minnesota<br>
</div>