<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>By that I mean, anywhere that MM:SS:FF is accepted, so is MM:SS (whose meaning is MM:SS:00) , and further, allowing MM:SS to be used regardless of the sample rate. Then the MM:SS:00 special case can be removed; the user will always use MM:SS when the sample rate is not 44100. The tests probably also have to be augmented to cover MM:SS, and possibly the man page and html docs.<br></span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Earl Chew
<earl_chew@yahoo.com><br> <b><span style="font-weight: bold;">To:</span></b> Josh Coalson <xflac@yahoo.com>; "flac-dev@xiph.org" <flac-dev@xiph.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Wednesday, May 2, 2012 11:13 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br>
<meta http-equiv="x-dns-prefetch-control" content="off"><div id="yiv41843406"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div><span>Josh,</span></div><div><span><br></span></div><div><span>Sure. I can try. Would you give me a more detailed description of the requirement ?</span></div><div><br><span></span></div><div><span>What exactly does "general MM:SS handling" mean ?</span></div><div><br><span></span></div><div><span>Earl<br></span></div><div><br></div> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Josh Coalson <xflac@yahoo.com><br> <b><span style="font-weight:bold;">To:</span></b> Earl Chew <earl_chew@yahoo.com>; "flac-dev@xiph.org"
<flac-dev@xiph.org> <br> <b><span style="
font-weight:bold;">Sent:</span></b> Tuesday, May 1, 2012 8:25:34 PM<br> <b><span style="font-weight:bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow <a target="_blank" href="http://metaflac_test.sh">metaflac_test.sh</a> to run to completion<br> </font> </div> <br><div id="yiv41843406"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div><span>Ah, I don't remember but it might have been a negative test that was supposed to give an error when used with the wrong sample rate.</span></div><div><span><br></span></div><div><span>Anyway, could you do another patch that updates to general MM:SS handling?<br></span></div><div><br><blockquote style="border-left:2px solid rgb(16, 16, 255);margin-left:5px;margin-top:5px;padding-left:5px;"> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div style="font-family:times new roman, new york, times,
serif;font-size:12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Earl Chew <earl_chew@yahoo.com><br> <b><span style="font-weight:bold;">To:</span></b> Josh Coalson <xflac@yahoo.com>;
"flac-dev@xiph.org" <flac-dev@xiph.org> <br> <b><span style="font-weight:bold;">Sent:</span></b> Thursday, April 26, 2012 3:12 PM<br> <b><span style="font-weight:bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br>
<div id="yiv41843406"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div><span>Josh,</span></div><div><br></div><div>I see my name is mentioned in passing ;-)</div><div><br></div><div>I submitted that patch because I thought it preferable to keep the test harness running.</div><div><br></div><div>Backing this change out would also entail changing <a rel="nofollow" target="_blank" href="http://metaflac_test.sh">metaflac_test.sh</a> accordingly, which at the time, I was hesitant to do.</div><div>At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass.</div><div><br></div><div>I'm ok either way.<br></div><div><br><span></span></div><div><span>Earl</span></div><div><br></div> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div style="font-family:times new roman, new york, times,
serif;font-size:12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1">
<b><span style="font-weight:bold;">From:</span></b> Josh Coalson <xflac@yahoo.com><br> <b><span style="font-weight:bold;">To:</span></b> "flac-dev@xiph.org" <flac-dev@xiph.org> <br> <b><span style="font-weight:bold;">Sent:</span></b> Wednesday, April 25, 2012 3:23:35 PM<br> <b><span style="font-weight:bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br><div id="yiv41843406"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div><span>I haven't checked git yet but I hope this patch has not gone in. I don't like the special case that this is creating.</span></div><div><br><span></span></div><div><span>It would be better to allow MM:SS everywhere but I consider that low priority.<br></span></div><div><br><blockquote style="border-left:2px solid rgb(16, 16,
255);margin-left:5px;margin-top:5px;padding-left:5px;"> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Earl Chew <earl_chew@yahoo.com><br> <b><span style="font-weight:bold;">To:</span></b> "flac-dev@xiph.org" <flac-dev@xiph.org> <br> <b><span style="font-weight:bold;">Sent:</span></b> Thursday, January 5, 2012 8:27 PM<br> <b><span style="font-weight:bold;">Subject:</span></b> [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br>
<div id="yiv41843406"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div>When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows <a rel="nofollow" target="_blank" href="http://metaflac_test.sh">metaflac_test.sh</a> to pass.</div><div><br></div></div></div></div><br>_______________________________________________<br>flac-dev mailing list<br><a rel="nofollow" ymailto="mailto:flac-dev@xiph.org" target="_blank" href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>http://lists.xiph.org/mailman/listinfo/flac-dev<br><br><br> </div> </div> </blockquote></div>
</div></div></div><br>_______________________________________________<br>flac-dev mailing list<br><a rel="nofollow" ymailto="mailto:flac-dev@xiph.org" target="_blank" href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br><a rel="nofollow" target="_blank" href="http://lists.xiph.org/mailman/listinfo/flac-dev">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br><br><br> </div> </div> </div></div></div><br><br> </div> </div> </blockquote></div> </div></div></div><br><br> </div> </div> </div></div></div><meta http-equiv="x-dns-prefetch-control" content="on"><br><br> </div> </div> </blockquote></div> </div></body></html>