<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Erik,</span></div><div><br><span></span></div><div><span>My working view has this as the last commit:</span></div><div><br><span></span></div><div><span>commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16<br>Author: David Schleef <ds@schleef.org><br>Date: Thu Aug 25 18:40:29 2011 -0700<br><br> Fix md5 structure clearing in previous commit<br></span></div><div><br></div><div><br></div><div>Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.</div><div><br></div><div><br></div><div>I set up another view using HEAD at git.xiph.org, and in this other view test_metaflac.sh fails.</div><div>With my change in place, the failure is a mismatch between information stored in the golden</div><div>file.<br></div><div><br></div><div><br></div><div>---
metaflac-test-files/case43-expect.meta 2012-02-02 08:52:57.000000000 -0800<br>+++ metaflac-test-files/out.meta 2012-02-03 11:37:13.000000000 -0800<br>@@ -10,9 +10,8 @@<br> METADATA block #1<br> type: 3 (SEEKTABLE)<br> is last: false<br>- length: 18<br>- seek points: 1<br>- point 0: sample_number=0<br>+ length: 0<br>+ seek points: 0<br> METADATA block #2<br> type: 4 (VORBIS_COMMENT)<br> is last: false<br></div><div><br></div><div><br></div><div>Do you have any more insight ?<br></div><div><br><span></span></div><div><span>Earl</span></div><div><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font size="2" face="Arial"> <hr size="1">
<b><span style="font-weight:bold;">From:</span></b> Earl Chew <earl_chew@yahoo.com><br> <b><span style="font-weight: bold;">To:</span></b> "flac-dev@xiph.org" <flac-dev@xiph.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Thursday, February 2, 2012 8:50:17 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br><div id="yiv142858607"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><div><span>Erik,</span></div><div><br><span></span></div><div><span>I'll resync and have another look.</span></div><div><br><span></span></div><div><span>Earl<br></span></div><div><br></div> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div style="font-family:times new roman, new york, times, serif;font-size:12pt;"> <div dir="ltr"> <font
size="2" face="Arial"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Erik de Castro Lopo <mle+la@mega-nerd.com><br> <b><span style="font-weight:bold;">To:</span></b> flac-dev@xiph.org <br><b><span style="font-weight:bold;">Cc:</span></b> Earl Chew <earl_chew@yahoo.com> <br> <b><span style="font-weight:bold;">Sent:</span></b> Wednesday, February 1, 2012 10:30:21 PM<br> <b><span style="
font-weight:bold;">Subject:</span></b> Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion<br> </font> </div> <br>Earl Chew wrote:<br><br>> When reading the INDEX from the cue sheet, the format MM:SS:FF format<br>> is disallowed if the sample frequency is not a multiple of 75 because<br>> the index would only be approximate. However, 00:00:00 is _exact_ because<br>> it denotes the start of the track, so allow it as a special case. This<br>> allows metaflac_test.sh to pass.<br><br>Thanks for this patch Earl, but unfortunately even with this patch in<br>place (and the exit 0 I added the script removed), test_metaflac.sh still<br>fails with:<br><br> test case43: --import-cuesheet-from... ERROR: metadata does not match<br> expected metaflac-test-files/case43-expect.meta<br><br>Would be great if you could have another look at this.<br><br>Cheers,<br>Erik<br>--
<br>----------------------------------------------------------------------<br>Erik de Castro Lopo<br><a rel="nofollow" target="_blank" href="http://www.mega-nerd.com/">http://www.mega-nerd.com/</a><br><br><br> </div> </div> </div></div></div><br><br> </div> </div> </div></body></html>