Josh,<br><br>I applied this patch and all the "make check" tests passed (but I do not have valgrind and I did not use --enable-exhaustive-tests during configure, so it isn't all the tests). Do you see anything suspicious about it?<br><br>--- flac-1.1.2.oldBuild/src/flac/decode.c 2005-01-24 20:13:46.000000000 -0800<br>+++ flac-1.1.2/src/flac/decode.c 2006-09-06 23:36:26.000000000 -0700<br>@@ -497,7 +497,7 @@<br> }<br><br> if((d->is_wave_out || d->is_aiff_out) && ((d->total_samples * d->channels * ((d->bps+7)/8)) & 1)) {<br>- if(flac__utils_fwrite("\000", 1, 1, d->fout) != 1) {<br>+ if(d->fout &&
flac__utils_fwrite("\000", 1, 1, d->fout) != 1) {<br> print_error_with_state(d, d->is_wave_out?<br> "ERROR writing pad byte to WAVE data chunk" :<br> "ERROR writing pad byte to AIFF SSND chunk"<br><br>Tom<br><br><b><i>Tom Goetze <tgoetze@yahoo.com></i></b> wrote:<blockquote class="replbq" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"> Date: Wed, 30 Aug 2006 00:00:56 -0700 (PDT)<br>From: Tom Goetze
<tgoetze@yahoo.com><br>Subject: Re: [Flac-dev] test_metaflac fails in make check for flac 1.1.2 after --add-padding is performed<br>To: Josh Coalson <xflac@yahoo.com>, flac-dev@xiph.org<br><br> <br><br><b><i>Josh Coalson <xflac@yahoo.com></i></b> wrote: <blockquote class="replbq" style="border-left: 2px solid rgb(16, 16, 255); padding-left: 5px; margin-left: 5px;"> <div>--- Tom Goetze <TGOETZE@YAHOO.COM>wrote:<br>> doing "make check" on flac-1.1.2, I get a segmentation fault <br>> <br>> ././test_metaflac.sh: line 51: 17370 Segmentation fault flac<br>> $*<br>> <br>> My linux distribution is a linuxfromscratch 6.1.1<br>> I built flac using blfs 6.1 directions:<br><br>> gcc version 3.4.3<br><br>hmm, two things would help. first change the first line of<br>test_metaflac.sh to<br><br>#!/bin/sh -x<br><br>when you run the script you will see the exact invocation of flac<br>before the crash. if you send be the FLAC file, that might
help.<br>also, if you can run the same command in gdb and get a backtrace<br>that would be another clue.<br><br>Josh<br><br></TGOETZE@YAHOO.COM></div></blockquote> <div>Seems like fwrite doesn't like to write to null. However, it seems clear from the code that using --test intentionally creates no outputfile for fwrite. </div> <div> </div> <div>src/flac/main.c: 1730 retval = flac__decode_wav(infilename, option_values.test_only? 0 : outfilename, option_values.analyze, option_values.aopts, options);</div> <div> </div> <div> </div> <div>Details below:</div> <div> </div> <div>(gdb) run<br>Starting program: /home/tom/sources/flac-1.1.2/src/flac/.libs/lt-flac --silent --test metaflac.flac</div> <div>Breakpoint 1, DecoderSession_process (d=0xbffff530) at
decode.c:500<br>500 if(flac__utils_fwrite("\000", 1, 1, d->fout) != 1) {<br>(gdb) print d<br>$1 = (DecoderSession *) 0xbffff530<br>(gdb) print d->fout<br>$2 = (FILE *) 0x0<br>(gdb) n</div> <div>Program received signal SIGSEGV, Segmentation fault.<br>0xb7ea7044 in fwrite () from /lib/libc.so.6<br>(gdb) bt<br>#0 0xb7ea7044 in fwrite () from /lib/libc.so.6<br>#1 0x0804ef09 in DecoderSession_process (d=0xbffff530) at decode.c:500<br>#2 0x08051275 in flac__decode_wav (infilename=0x8341978 "metaflac.flac", outfilename=0x0, analysis_mode=0, aopts=<br> {do_residual_text = 0, do_residual_gnuplot = 1}, options=<br> {common = {continue_through_decode_errors = 0, replaygain_synthesis_spec = {apply = 0, use_album_gain = 1, limiter = RGSS_LIMIT__HARD,
noise_shaping = NOISE_SHAPING_LOW, preamp = 0}, is_ogg = 0, use_first_serial_number = 1, serial_number = 0, skip_specification = {is_relative = 0, value_is_samples = 1, value = {seconds = 0, samples = 0}}, until_specification = {is_relative = 0, value_is_samples = 1, value = {seconds = 0, samples = 0}}, has_cue_specification = 0, cue_specification = {has_start_point = -1207954168, has_end_point = 0, start_track = 3086395392, start_index = 40, end_track = 3086395392, end_index = 3086396416}}}) at decode.c:203<br>#3 0x0805a507 in decode_file (infilename=0x8341978 "metaflac.flac") at main.c:1730<br>#4 0x0805c241 in do_it () at main.c:486<br>#5 0x0805ca7b in main (argc=4, argv=0xbffffa34) at main.c:284</div> <div><br>And output of adding -x:</div> <div> </div> <div>options: -P 4096 -b 1152 -l 0 -q 0 -r 2,2 -V<br>sh: Verify OK, wrote 554232 bytes, ratio=0.967<br>+ chmod +w metaflac.flac<br>+ check_flac<br>+ run_flac --silent --test metaflac.flac<br>+
'[' xno = xyes ']'<br>+ flac --silent --test metaflac.flac<br>././test_metaflac.sh: line 51: 7636 Segmentation fault flac $*<br>+ die 'ERROR in metaflac.flac'<br>+ echo ERROR in metaflac.flac<br>ERROR in metaflac.flac<br>+ exit 1<br>FAIL: ./test_metaflac.sh</div> <div> </div> <div>Would it change functionality to add another condition about non-null outputfile to the flac__decode_wav routine on decode.c:500?</div> <div> </div> <div>Tom</div><div> </div><hr size="1">Want to be your own boss? Learn how on <a href="http://us.rd.yahoo.com/evt=41244/*http://smallbusiness.yahoo.com/r-index"> Yahoo! Small Business.</a> </blockquote><br><p> 
<hr size=1>Want to be your own boss? Learn how on <a href="http://us.rd.yahoo.com/evt=41244/*http://smallbusiness.yahoo.com/r-index"> Yahoo! Small Business.</a>