[flac-dev] about "cpu.h: Fix compiler detection" patch

lvqcl lvqcl.mail at gmail.com
Thu Feb 16 17:34:41 UTC 2017


Erik de Castro Lopo wrote:

> the bug *before* the logic is evaluated. My current solution in
> the above PR is to avoid `__has_attribute` and use this:
>
>     #elif defined __clang__ && (__clang_major__ > 3 || \
>           (__clang_major__ == 3 && __clang_minor__ >= 6)) /* clang */
>
> which I have tested with clang 3.6. If someone has an earlier version
> of clang and can verify that it work, I'll drop the version number.


Maybe it's simpler to add

#ifndef __has_attribute
#define __has_attribute(x) 0
#endif
#ifndef __has_builtin
#define __has_builtin(x) 0
#endif

somewhere before their use? (see  
http://clang.llvm.org/docs/LanguageExtensions.html )


More information about the flac-dev mailing list