[flac-dev] About the commit "Fix compiler warnings from new compiler flags."

lvqcl lvqcl.mail at gmail.com
Mon Jan 18 09:03:28 PST 2016


https://git.xiph.org/?p=flac.git;a=commit;h=91790ef965553fd6d76e1f51b55dc4de3b54ad4b

It (among other things) changes (void)chown(...) into FLAC_CHECK_RETURN(chown(...)).

I don't know what warning "(void)chown(...);" raises, and I cannot test it
because I don't have Linux, but FLAC_CHECK_RETURN calls printf, and IMHO
the library function shouldn't do it. So it makes sense to revert
this part of the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no_check_return.patch
Type: application/octet-stream
Size: 873 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20160118/37851c3d/attachment.obj 


More information about the flac-dev mailing list