[flac-dev] num_comments==0 and comments==0

[lvqcl]

About the removed assert in this commit: http://git.xiph.org/?p=flac.git;a=commitdiff;h=bc5113007a53be2c621d5eb5f4485eddf947ef37

It looks reasonable that if x.num_comments == 0 then x.comments is also NULL.
Otherwise there's probably a leak somewhere that should be fixed.



I found several places where the situation is reverse:
comments can be 0 but num_comments is not; IMHO it makes sense
to fix them even if there are no crashes (yet?).

The patch is attached (of course it can't fix the removed assert because it
doesn't fix any leak).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: num_comments.patch
Type: application/octet-stream
Size: 2693 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20150704/c8165f11/attachment-0001.obj