[flac-dev] questions about flac code

Erik de Castro Lopo mle+la at mega-nerd.com
Sat Aug 8 16:34:43 PDT 2015

lvqcl wrote:

> 1) There was the commit "Remove un-needed test for NULL before free"
> but even now there are many places in FLAC codebase that check a pointer
> before calling free().
> Does it make sense to do something with this code, or it's simpler to
> leave it as is?

I've just had another look at this. There are a huge number of these
which makes me think its probably not worth the code churn to fix
them. The check is not wrong so much as un-necessary.

> 2) Some time ago I sent a patch that fixes potential memleaks
> in libFLAC, but despite this approval -
> <http://lists.xiph.org/pipermail/flac-dev/2015-July/005530.html>
>   - I cannot see the code in the current git. What's the reason?

Sorry, I think I decided that this one needed testing with Valgrind
before pushing to the repo and then I got distracted and never finished

Valigrind testing now. You will either see this patch commited in
the next couple of hours or you will see a follow email to this
one :-).

Erik de Castro Lopo

More information about the flac-dev mailing list