[flac-dev] About a comment in stream_decoder.c

[Miroslav Lichvar]

On Mon, Apr 20, 2015 at 08:00:20PM +0300, lvqcl wrote:
> I don't understand the comment in src/libFLAC/stream_decoder.c:
> 
> 		/*@@@@@@ technically not pessimistic enough, should be more like
> 		if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) )
> 		*/
> 		if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32)

> which is equivalent to the current
> 
> 	bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32
> 
> So IMHO the comment is incorrect.

Yeah, the current code looks right to me. I think we already discussed
this some time ago. I'd just remove that comment.

-- 
Miroslav Lichvar