[flac-dev] Patch to improve malformed vorbiscomment handling

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Sep 26 05:21:18 PDT 2014


Janne Hyvärinen wrote:

> Patch v2, now handles more malformed cases. Original patch was for a 
> file for which I had a sample from a user but this allows handling some 
> manually broken test cases.


Err, I'm getting warning messages on that patch:

  CC       metadata_iterators.lo
metadata_iterators.c: In function ‘read_metadata_block_data_vorbis_comment_cb_’:
metadata_iterators.c:2238:12: error: comparison between ‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum <anonymous>’ [-Werror=enum-compare]
  if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) goto skip;
            ^
metadata_iterators.c:2256:13: error: comparison between ‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum <anonymous>’ [-Werror=enum-compare]
   if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) {
             ^



Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list