[flac-dev] [PATCH 2/4]

lvqcl lvqcl.mail at gmail.com
Sat Sep 20 16:43:40 PDT 2014


Erik de Castro Lopo wrote:

>> This patch adds new SSE code: it's simpler but not faster so
>> this new version is disabled by default. Maybe it will be faster
>> on newer CPUs though...
>
> I'm a little sceptical about adding code that by default is not
> being compiled.

FLAC__fixed_compute_residual() has the following code:

#if 1 /* OPT: may be faster with some compilers on some systems */
	residual[i] = data[i] - (data[i-1] << 1) + data[i-2];
#else
	residual[i] = data[i] - 2*data[i-1] + data[i-2];
#endif

So I thought that adding a different algorithm to calculate err1
variable won't hurt.

...I just noticed that I forgot to write something explanatory
after "[PATCH 2/4]" in the subject of the original message.


More information about the flac-dev mailing list