[flac-dev] [PATCH] for configure.ac

[Erik de Castro Lopo]

lvqcl wrote:

> lvqcl wrote:
> 
> > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty,
> > even if x86intrin.h is not available.
> >
> > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true':
> 
> The patch is attached. Please check it.

Looks good. I need to do a little testing.

> > 3) configure --disable-sse  prints:
> > "    SSE optimizations : ................... no"
> > but this option actually doesn't disable SSE, so this message
> > is a bit misleading.
> 
> Instead of the current message
> 
> 	echo "    SSE optimizations : ................... ${sse_os}"
> 
> it's technically more correct to write:
> 
> 	echo "    OS is guaranteed to support SSE : ..... ${sse_os}"
> 
> but this message is much less comprehensible.

This is also a little misleading as its not the OS we are checking
for SSE support but the compiler. I'll fix this.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/