[flac-dev] Include directories

Erik de Castro Lopo mle+la at mega-nerd.com
Sun Jun 15 21:48:04 PDT 2014


Erik de Castro Lopo wrote:

> lvqcl wrote:
> 
> > Some projects/makefiles add both 'include' and 'include/share'
> > to the list of additional include directories.
> 
> I think that is suboptimal.
> 
> > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h'
> > as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h".
> > 
> > Also src/share/replaygain_analysis/replaygain_analysis.c includes
> > "replaygain_analysis.h", not "share/replaygain_analysis.h".
> > 
> > Does it make sense? or is it better to explicitely add "share/" prefix
> > and remove 'include/share' from the list of include directories?
> 
> Thanks for pointing this out. I'll fix it.


Ok, done for the autotool build system. Would appreciate it if someone
could look that the VS build files.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list