[flac-dev] Typos in the FLAC codebase
lvqcl.mail at gmail.com
Sun Jun 1 02:27:08 PDT 2014
Erik de Castro Lopo wrote:
>> 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)'
>> Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__,
>> not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs
>> we use the prefix FLaC__ instead of FLAC__ since autoconf triggers off 'AC_' in strings".
> I this was was a bug in and earlier version of autoconf, but I fixed
> it anyway, just for the sake of uniformity.
But such names (FLaC__NO_ASM, FLaC__CPU_IA32, FLaC__CPU_PPC, FLaC__USE_3DNOW, ...)
begin with 'FLaC__' only in configure.ac. In all source files (.c, .h, .cpp)
they begin with 'FLAC__' (all caps).
More information about the flac-dev