[flac-dev] FIxed rest of cast-align warnings

Erik de Castro Lopo mle+la at mega-nerd.com
Tue Jul 1 03:11:11 PDT 2014

Martijn van Beurden wrote:

> These patches indeed fix the -Wcast-align warnings, but the new 
> MD5 tests fail
> > +++ libFLAC unit test: md5
> >
> > testing FLAC__MD5Init ... OK
> > testing that FLAC__MD5Final clears the MD5Context ... OK
> > testing FLAC__MD5Accumulate (channels=1, bytes_per_sample=1) ...
> > FAILED, expected MD5 sum b2bb8775b7d5bf59c36c8637293a4602 but 
> > got 419123315a22592e3170b67d0aa26916
> However, using the binary on actual FLAC files (with flac -t) 
> doesn't give any errors of mismatching md5 sums, so maybe the 
> problem is in the test itself?

Yes, the tests were broken and were only passing by replying on
undefined behaviour.

Tests fixed, and pass on amd64/Linux, powerpc64/Linux and armh/Linux.

Erik de Castro Lopo

More information about the flac-dev mailing list