[flac-dev] PATCH for lpc_asm.nasm

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Jan 17 12:57:01 PST 2014


lvqcl wrote:

> 1) Two comments ";ASSERT(lp_quantization <= 31)" in the new functions ..._wide_asm_ia32()
> -- just to mention this constraint.
> (max. possible value of lp_quantization is 15, so it's not a problem)
> 
> 
> 2) "mov cl, ..." was replaced with "mov ecx, ..." (again Agner Fog, optimizing_assembly.pdf)
> 
> summary: write to a partial register may result in false dependencies
> between instructions, so it is better to avoid it.
> (also bitreader_asm.nasm and stream_encoder_asm.nasm both have "mov ecx, ..."
> instructions, and no "mov cl, ...").

Applied. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list