[flac-dev] [PATCH] for win_utf8_io.c

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Aug 8 20:04:50 PDT 2014


lvqcl wrote:

> For better readability the patch is divided by 3 parts.
> 
> Part #1: for a bit better security replace
>      vsprintf(utmp, format, argptr)
> with
>      vsnprintf_s(utmp, 32768, _TRUNCATE, format, argptr)
> 
> 
> Part #2: potential memleak fixed: utf8argv[i] are not freed
> when utf8argv itself is freed.
> 
> 
> Part #3: 'if (ret != 0) break;' line seems redundant.

Applied al three. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list