[flac-dev] New routine: FLAC__lpc_compute_autocorrelation_asm_ia32_sse_lag_16

[Erik de Castro Lopo]

lvqcl wrote:

> > * libFLAC and FLAC__ALIGN_MALLOC_DATA : Looks sane but doesn't apply.
> > * MSVC and M_LN2 : Looks sane but doesn't apply.
> 
> It is also possible to add /D "_USE_MATH_DEFINES" as an additional option
> to libFLAC_static.vcproj and libFLAC_dynamic.vcproj. Don't know what is
> better. What do you think?

Adding _USE_MATH_DEFINES to the *.vcproj files seems less intrusive,
Lets go with that,
 
> > * bitmath.h: 1 typo, 1 warning : I don't see why the type has to change.
> 
> Declarations from MSDN:
>      unsigned char _BitScanReverse(unsigned long * Index, unsigned long Mask);
>      unsigned char _BitScanReverse64(unsigned long * Index, unsigned __int64 Mask);
> 
> FLAC uses them as:
>      _BitScanReverse(FLAC__uint32* idx, FLAC__uint32 v);
> and
>      _BitScanReverse64(FLAC__uint64* idx, FLAC__uint64 v);

Ok, there is the problem. The way MSDN defines them is different to the
way FLAC uses them. Is it possible its a typo in MSDN's documentation?

Something not right there.

> Also I noticed that all projects with '_static' suffix produce static
> library files (*.lib), projects with '_dynamic' suffix produce dynamic
> library files (*.dll), and projects without suffixes produce executables
> (*.exe). The only exception is win_utf8_io. Should it be renamed to win_utf8_io_static?

That would make sense.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/