[flac-dev] [PATCH 1/2] Revert "configure.ac : If gcc is version 4.2, use -fgnu89-inline."

[Erik de Castro Lopo]

Erik de Castro Lopo wrote:

> Rafaël Carré wrote:
> 
> > This reverts commit 2860f1780ca92c779ee0a2c545ae1b9c4818dc53.
> > 
> > Conflicts:
> > 	configure.ac
> > 
> > Do not use -fgnu89-inline as it can emit duplicate symbols for
> > inline functions that are declared in multiple object files
> > being linked together.
> > 
> > For example on clang 5.0 targetting iOS
> > (clang advertises itself as gcc 4.2, the last GPL version of gcc)
> 
> Ah yes, I hit this problem in another project. However I came up
> with a better solution, to detect the difference between GCC and
> Clang. I'll port that fix over to FLAC in the next couple of days.

The fact that Apple/Clang compiler advertises itself as being GCC,
but diverges from the actual behaviour of GCC is breaking software
all over the internet.

I hope the Apple/Clang people learn from this mistake.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/