[flac-dev] Anything else for Flac 1.3.0?

[Erik de Castro Lopo]

Xiyue Deng wrote:

> On Sun, May 26, 2013 at 5:54 AM, Xiyue Deng <manphiz at gmail.com> wrote:
> > On Sun, May 26, 2013 at 5:41 AM, Martijn van Beurden <mvanb1 at gmail.com> wrote:
> >> On 26-05-13 14:34, Xiyue Deng wrote:
> >>>
> >>> Also I have a patch fixing bootstrap on Mac OS X that may also be on
> >>> moderation queue. It will be great it can be reviewed and given a green
> >>> light.
> >>
> >>
> >> I'm not sure who has access to the queue, uploading it somewhere and sending
> >> a link might be faster :)
> >
> > I've uploaded the patch to github, which can be found at [1]. Here are
> > some explanations.
> >
> > Currently flac's autogen.sh will check for gettext command and relies
> > on gettext and iconv installation for various m4 scripts. However on
> > Mac OS X, the gettext/iconv utilities are partially installed on Mac
> > OS X: it doesn't have gettext command, but the libraries and msg* are
> > provided, also the m4 scripts are missing. So I have crafted a patch
> > that avoids checking for gettext command on Mac OS X and imported the
> > required m4 scripts so it can be bootstrapped and built without custom
> > gettext and iconv installations.
> >
> > Please note that only autogen.sh is modified, and other m4 files are
> > added from gettext/iconv installations.
> >
> > [1] https://raw.github.com/manphiz/patches/master/patch-flac-macosx.patch
> 
> Forgot to send to mailling list. Resend as per request by Martijn.

Applied. Thanks.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/