[flac-dev] FLAC currently won't compile for Android [bisected]

[Ulrich Klauer]

Felix Homann wrote:

> utils.c: In function 'get_console_width':
> utils.c:181:17: error: storage size of 'w' isn't known
> utils.c:181:17: warning: unused variable 'w' [-Wunused-variable]

[That's apparently src/flac/utils.c.]

Strange thing. It looks like "struct winsize" isn't known anymore.

>  03a9e6064d406e3656afacdbe50e8e47ebfa0de3 is the first bad commit

-#if defined(__GNUC__)
+#if defined(__GNUC__) && (__GNUC__ > 4) && (__GNUC_MINOR__ > 4)

Arguably, this should have said ">= 4" at least for __GNUC__, because  
otherwise the condition will always be false (until a GCC 5.x is  
released). If sys/param.h is present, it causes that header to be  
included; if it is not present, it causes flac_max and flac_min to be  
undefined. (I guess that isn't intended either.) But I don't see how  
this causes the problem in src/flac/utils.c, which doesn't use any of  
MIN, MAX, flac_min, flac_max.

Felix, is HAVE_SYS_PARAM_H set or unset in an Android build? This  
information would eliminate one of the possibilities.

Ulrich