[flac-dev] Patch to add Unicode filename support for win32 flac

Erik de Castro Lopo mle+la at mega-nerd.com
Sun Mar 17 03:37:58 PDT 2013


JonY wrote:

> On 3/17/2013 10:33, Janne Hyvärinen wrote:
> > Here's a patch that makes MSVC compiled flac.exe able to use wildcards
> > and encode/decode files with Unicode characters in names. It may not be
> > the prettiest code but it fulfills its primary purpose.
> > I tried to alter FLAC code as little as possible. It replaces argv with
> > utf-8 encoded version and only converts to usable Unicode for file
> > functions. That means printed texts and tags that contain non-ascii
> > characters will be broken, but it is fixable if these changes are
> > acceptable.
> > 
> 
> Can this be reworked without the defines? This way, it should support
> mingw builds too.

+1

I'd like to see some way to do this to:

 a) Make this usable from MinGW compiled binaries.
 b) Reduce the the amount of inline #ifdef hackery.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list