[flac-dev] flac 1.3.0pre2 pre-release

[Miroslav Lichvar]

On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
> Take, for example, the function FLAC__bitreader_is_consumed_byte_aligned.
> It is prototyped in bitreader.h  It is used in stream_decoder.c, so it
> must be defined and made available to the linker ("external definition"). 
> However, the only definition in bitreader.c has been declared inline.
> 
> From 6.7.4.6
> An inline definition does not provide an external definition for the
> function, and does not forbid an external definition in another
> translation unit. An inline definition provides an alternative to an
> external definition, which a translator may use to implement any call to
> the function in the same translation unit.

My understanding is that it's not an "inline definition" as there is
a non-inline declaration in bitreader.h.

If there are no better solutions to fix the problem, I'd suggest to
#define inline to nothing for MSVC.

-- 
Miroslav Lichvar