[flac-dev] flac 1.3.0pre2 pre-release

[Janne Hyvärinen]

On 11.3.2013 13:05, Erik de Castro Lopo wrote:
>> It includes Ben Allison's MSVC changes and JonY's MinGW changes with
>> some tweaks to make both environments happy.
> Please don't do that. Adding bits of other patches makes it more
> difficult to evaluate and review this patch which is already difficult
> to review because of its size.

Sorry, I'm new at this. I don't know how things should be handled.

>> And I had to do some more
>> inline changing to get my MSVC 2012 to compile the sources.
> I would still like to have this problem explained to me.

With the sources as they are compiling produces these errors (this on 
MSVC 2012 SP1 Express):

Error    1    error LNK2001: unresolved external symbol 
_FLAC__bitreader_bits_left_for_byte_alignment 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) 
flac
Error    2    error LNK2001: unresolved external symbol 
_FLAC__bitreader_is_consumed_byte_aligned 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) 
flac
Error    3    error LNK2001: unresolved external symbol 
_FLAC__bitreader_read_uint32_little_endian 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) 
flac
Error    4    error LNK2001: unresolved external symbol 
_FLAC__bitreader_get_input_bits_unconsumed 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_decoder.obj) 
flac
Error    5    error LNK2001: unresolved external symbol 
_FLAC__bitwriter_write_raw_uint64 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) 
flac
Error    6    error LNK2001: unresolved external symbol 
_FLAC__bitwriter_write_raw_int32 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) 
flac
Error    7    error LNK2001: unresolved external symbol 
_FLAC__bitwriter_write_byte_block 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) 
flac
Error    8    error LNK2001: unresolved external symbol 
_FLAC__bitwriter_write_raw_uint32_little_endian 
G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(stream_encoder_framing.obj) 
flac
Error    9    error LNK2001: unresolved external symbol 
_safe_malloc_mul_2op_ 
G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac
Error    10    error LNK1120: 9 unresolved externals 
G:\Programming\flac-1.3.0pre2\objs\release\bin\flac.exe    flac

Error 9 is related to the location of _safe_malloc_mul_2op_. It's 
easiest to fix by having the code in utf8.c.
>> There may still be some bug in FLAC's large input wav handling as the
>> test FLAC I created by encoding over 22 hours of 24 bit data makes
>> foobar2000 report one sample mismatch in reported and decoded length. Or
>> it's a rounding bug in foobar2000.
> Is it not possible to test this without involving foobar2000?
>

It is and I actually verified it yesterday. I used the command-line flac 
to decode the file into RAW format and calculated sample count by 
dividing it with bytes per sample and channel count. It matched the 
reported sample count exactly, so it's not a bug in FLAC.