[flac-dev] exhaustive-model-search issue results in multi-gigabyte FLAC file

Leigh Dyer leigh at bandcamp.com
Wed Jul 17 17:37:41 PDT 2013


On 17/07/13 19:45, Erik de Castro Lopo wrote:
> Martijn van Beurden wrote:
>
>> You've exposed at least two very serious FLAC bugs,
>> namely a malfunctioning RICE2-partition encoder and a bug concerning
>> choosing verbatim frames over fixed/lpc frames.
>
> The second, not choosing verbatim frames over fixed/lpc frames is almost
> certainly a direct result of the first problem.
>
> The fix was changing one local variable from FLAC_uint32 to FLAC_uint64
> in function precompute_partition_info_sums_().
>
>      https://git.xiph.org/?p=flac.git;a=commit;h=6f7ec60c7e7f05f5ab0b1cf6b7b0945e44afcd4b

Great! After updating from git, I can confirm that both the snippet that 
I posted here, and the full original track, both encode as expected 
using -7.

Thanks
Leigh


More information about the flac-dev mailing list