[flac-dev] exhaustive-model-search issue results in multi-gigabyte FLAC file

Miroslav Lichvar mlichvar at redhat.com
Wed Jul 17 03:06:23 PDT 2013

On Wed, Jul 17, 2013 at 07:45:53PM +1000, Erik de Castro Lopo wrote:
> The fix was changing one local variable from FLAC_uint32 to FLAC_uint64
> in function precompute_partition_info_sums_().
>     https://git.xiph.org/?p=flac.git;a=commit;h=6f7ec60c7e7f05f5ab0b1cf6b7b0945e44afcd4b

I don't like this fix. It will probably hurt performance with 16-bit
data and it won't fix the problem in the assembly code.

I think the check if 32-bit accumulator is enough should be improved
instead if possible.

Miroslav Lichvar

More information about the flac-dev mailing list