[flac-dev] Tests not aborting when appropriate

Erik de Castro Lopo mle+la at mega-nerd.com
Wed Apr 24 21:39:20 PDT 2013

Erik de Castro Lopo wrote:

> Martijn van Beurden wrote:
> > On 24-04-13 14:34, Erik de Castro Lopo wrote:
> > > That's an error in the awk script, which is embedded in the shell 
> > > script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll 
> > > investigate that futher. 
> > 
> > On my system awk links to mawk 1.3.3
> Yep fails on my system with maxk 1.3.3 too.
> Do you have any other versions om awk on your system? Gawk maybe?
> > awk stops, but the script keeps running here. For some reason exit (and 
> > die) don't function inside this loop.
> The problem is that the failure in the awk script isn't recognised as
> a failure in the shell script.

Well I haven't fixed the problem with the shell script not recognising
the failure of the awk script, but I have fixed the awk script in this

    commit 69c44a51de295a6eb91ab0fdb1777d222395dab0
    Author: Erik de Castro Lopo <erikd at mega-nerd.com>
    Date:   Thu Apr 25 13:53:21 2013 +1000

        test/test_metaflac.sh: POSIXify embedded awk script.
        The embedded awk script was using the 'lshift' function which
        apparently only exists in GNU auk (gawk) and definitely does not
        exist in mawk.

Erik de Castro Lopo

More information about the flac-dev mailing list