[flac-dev] Metaflac UTF-8 fixes

Erik de Castro Lopo mle+la at mega-nerd.com
Wed Apr 24 16:02:44 PDT 2013


Janne Hyvärinen wrote:

> Changing it to #define PPR if(filename) { if(raw) { 
> printf("%s:",filename); } else { flac_printf("%s:",filename); } }

Thanks. Applied.

> makes GCC happy.

Its really about more than making GCC happy. The if statement
was genuinely an ambiguous compile. See the 'Dangling Else'
issue:

   https://en.wikipedia.org/wiki/Dangling_else

Anyway, fixed now.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list