[flac-dev] flac 1.3.0pre3 pre-release

Dagobert Michelsen dam at opencsw.org
Fri Apr 5 04:24:53 PDT 2013

Hi Erik,

Am 01.04.2013 um 12:40 schrieb Erik de Castro Lopo <mle+la at mega-nerd.com>:
> The latest pre-release is here:
>    http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz
> but there will probably need to be at least one more.
> I've tested this on
>    x86_64-linux
>    powerpc-linux
>    i386-openbsd5.2
>    i386-freebsd9
> The majority of changes since the last pre-release is the addition of
> Janne Hyvärinen's utf8 I/O functionality. Janne's original patch was
> MSVC only. I hacked it to work with MinGW as well (including cross
> compiling from Linux).
> I need people to test this with MSVC (I may have broken something)
> and with MinGW (I can cross-compile but I can't run the tests).
> Please report back successes and failures (hopefully with patches).

There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following compile errors:

>   CC     bitreader.lo
> "bitreader.c", line 494: warning: implicit function declaration: MIN
>   CC     bitwriter.lo
> "bitwriter.c", line 273: reference to static identifier "bitwriter_grow_" in extern inline function
> "bitwriter.c", line 277: warning: implicit function declaration: MIN
> "bitwriter.c", line 316: reference to static identifier "bitwriter_grow_" in extern inline function
> cc: acomp failed for bitwriter.c
> gmake[4]: *** [bitwriter.lo] Error 1

Either bitwriter_grow_ can be made non-static or FLAC__bitwriter_write_zeroes not inline or
also static to work around this.

The attached patch fixes the issue.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-make-functions-static-which-are-used-by-inlin.patch
Type: application/octet-stream
Size: 1440 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130405/70c28bfc/attachment.obj 
-------------- next part --------------

The implicit function MIN should according to src/libFLAC/include/private/macros.h be
in sys/param.h if that header file is available. On Solaris sys/param.h is there but does
not have MIN/MAX macros. The attached patch explicitly defines MIN and MAX on Solaris.
It may be useful to detect the presence of MIN and MAX in sys/param.h and make the
definition depend on that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Provide-implementation-for-MIN-and-MAX-if-system-doe.patch
Type: application/octet-stream
Size: 1203 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130405/70c28bfc/attachment-0001.obj 
-------------- next part --------------

Apart from that it seems to compile fine.

Best regards

  -- Dago

"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896

More information about the flac-dev mailing list