[flac-dev] Regression fixed

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Oct 12 04:44:02 PDT 2012

Hi all,

I just pushed a commit which fixes a nasty regression in FLAC. 


> author Erik de Castro Lopo <erikd at mega-nerd.com>
> committer Erik de Castro Lopo <erikd at mega-nerd.com>
> commit fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6
> Fix a regression that severely impacted compression levels.
> Regression was introducted in commit 8bbbf56403808ff75126cd0840a936aedbc4113b
> (Feb 1 19:58:09 2012) when fixing compiler warnings. In src/libFLAC/lpc.c the
> line:
>         ref[i] = (r/=err);
> was erroniously removed because the left hand side, ref[i] was never used.
> Obviously, the correct thing to do was to replace that line with:
>         r /= err;
> This code has not been officially released. The only people who would have
> been affected are people who compiled FLAC from git between February and
> now.
> The only adverse affect of this error was that compression ratio would have
> been severely compromised. No audio is lost, and if anyone has a file that
> compressed with a bad version of FLAC can decompress it to WAV and then
> re-compress with a fixed version.

I am in the process of putting together a test for the compression ratio.

Erik de Castro Lopo

More information about the flac-dev mailing list