[flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

[Bastiaan Timmer]

--- On Tue, 5/8/12, Bastiaan Timmer <basjetimmer at yahoo.com> wrote:

> From: Bastiaan Timmer <basjetimmer at yahoo.com>
> Subject: Re: [flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things
> To: flac-dev at xiph.org
> Date: Tuesday, May 8, 2012, 3:13 PM
> --- On Tue, 5/8/12, Erik de Castro
> Lopo <mle+la at mega-nerd.com>
> wrote:
> 
> > Honestly, I really doubt this is a bug in valgrind :-).
> How
> > were you testing
> > this?
> 
> Well, I've read that there have been bugs in valgrind, were
> SSE optimized versions of strlen() do guaranteed safe
> overreads of memory, but valgrind wasn't aware the overreads
> were safe.

I am now more certain this is a valgrind bug in handling GNU's optimized strlen() (still existing in current valgrind 3.7.0). The code looks fine and when building flac with '-fno-builtin-strlen' valgrind reports no errors.