[flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

[Erik de Castro Lopo]

Bastiaan Timmer wrote:

> Attached is a patch that adds 5 missing

Patch applied. Thanks.

> Looking at the FLAC__metadata_object_cuesheet_* FLAC__metadata_
> object_picture_* functions, it looks like the corresponding FLAC++
> classes are already complete. Maybe some functions are missing from
> CueSheet::Track. If nobody objects, I will take a look later this
> week.

Thanks.

> Also, I've noticed that on my system, flac will not compile with
> --enable-debug, because some functions that use 'PRId64' get compiled
> in, but no included header defines 'PRId64'.

Fixed, thanks.

> Lastly, the reason I tried to compile with debug was some invalid read
> sizes reported by valgrind when creating a VorbisComment::Entry. The
> invalid read is reported in set_field_name() at line 653 (
> src/libFLAC++/metadata.cpp), where strlen() is used on the newly created
> char *field_name_. I could not see anything wrong with the code though,
> and strangely enough just calling printf on the field_name_ 1 line before
> the strlen() removes all valgrind errors. So I'm not sure what's going on,
> but it's probably a bug in valgrind, maybe somebody on this list knows?

Honestly, I really doubt this is a bug in valgrind :-). How were you testing
this?

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/