[flac-dev] [PATCH] Add missing functions to SeekTable class

[Cristian Rodríguez]

El 06/05/12 19:18, Josh Coalson escribió:
>> From: Cristian Rodríguez<crrodriguez at opensuse.org>
>
>> Sent: Sunday, May 6, 2012 8:24 AM
>>
>> El 05/05/12 02:23, Bastiaan Timmer escribió:
>>>   The attached patch adds the missing FLAC__metadata_object_seektable_*()
>>> functions from FLAC's metadata object methods (FLAC/metadata.h) to
>>> FLAC++'s SeekTable class. Of the 11 functions in the C API, only 4 are
>>> currently in the C++ API, this patch adds the missing 7.
>>>
>>>   If this patch is ok, VorbisComment will be next. A quick look tells me only
>>> 5 out of 13 FLAC__metadata_object_vorbiscomment*() functions from
>>> FLAC/metadata.h exist in FLAC++'s VorbisComment class.
>>>
>>>   Bas Timmer
>>>
>> This patch looks fine to me.. if applied we either need to raise the C++
>> library SOVERSION and/or add a linker versioning script for *nix systems
>> though.
>
> Looks good to me to.  Erik, are you keeping up with patches?  Lately I've only
> been able to follow along.
>
> The soname is a good point: the flac release numbers are tied to the format
> and I rely on the sonames to manage binary compatibility.  Some maintainers
> don't like it but I think it's important for users:
> http://flac.sourceforge.net/faq.html#api__release_versioning

Yes, The soname change is an annoyance for distributions but if there is 
no "linker version script" it is the only possible way to get package 
managers to do the right thing on updates/upgrades.