[flac-dev] PATCH: Add test for metaflac --add-replay-gain

[Earl Chew]

Erik,

Thanks for the update. It certainly was a strange problem to debug.


Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Sunday, March 18, 2012 1:36:42 PM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
 
Earl Chew wrote:

> I cannot reproduce the problem you see with either dash(1) or bash(1).

Just found something really werid. I opened the patch in a text editor
that doesn't support unicode and found this:

    +Â Â Â Â awk -- '
    +Â Â Â Â BEGIN {
    +Â Â Â Â Â Â Â Â Â Â Â  samplerate = '$1';

Everywhere there was supposed to be a space (hex 0a) there was a pair
(hex c2 0a). In my regular unicode aware editor, the hex c2 0a pair
just showed up as a space. I just checked and your original patch also
has these extra bytes. This may be something added by YahooMail.

With the cruft removed, the patch applied and the tests ran correctly.

I'll commit and push after a little testing.

Thanks.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120318/e3bc77bc/attachment.htm