[flac-dev] A few patches to git MASTER

[Erik de Castro Lopo]

Hi Jaren,

Sorry for the delat dealing with these patches.

Jaren Stangret wrote:

> Below are the patches supplied by Gentoo (merged against MASTER) and with
> the Changelog explanations of them as well as the discussion link
> surrounding the patch:

Unfortunately the Gentoo changelog explanations are a little lacking
and very Gentoo specific.

> 
> *flac-9999-asm.patch:*
> *28 Sep 2007; Samuli Suominen <drac at gentoo.org>*
> +files/flac-1.2.1-asm.patch,
>   Fix TEXTRELs using patch from PaX Team from bug 193222 and while at it,
>   attempt to clean up ebuild a bit. Revert last commit restoring elibtoolize
>   for fbsd since eautoreconf allready does libtoolize.
> 
> *Gentoo bug where this is discussed:*
> *https://bugs.gentoo.org/show_bug.cgi?id=193222*

I followed those links and did some reading and came up with a 
commit message that made sense for FLAC.

> *flac-9999-asneeded.patch*
> *20 Sep 2007; Samuli Suominen <drac at gentoo.org>*
>   +files/flac-1.2.1-asneeded.patch,
>   Version bump.
> 
> *There isn't a bug detailing why this patch is here, but I believe it's to
> allow the --as-needed flag to the bfd linker.  More information can be
> found here:*
> *http://www.gentoo.org/proj/en/qa/asneeded.xml*

I've read all that and I still can't figure out why that patch is
needed.

> *flac-9999-ogg-m4.patch*
> *28 Mar 2011; Arun Raghavan <ford_prefect at gentoo.org>*
>   +files/flac-1.2.1-ogg-m4.patch:
>   Update the shipped version of ogg.m4 so that users of libflac don't get a
> ton of libtool warnings while linking.

Same for that one.

I am happy to take patches but I need information about what they do
and why.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/