[flac-dev] [PATCH] Remove even more CPP hackery

[Dave Yeo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/08/12 01:32 am, Erik de Castro Lopo wrote:
> Dave Yeo wrote:
> 
>> Another try
> 
> Actually there are still some issues with this patch,  mainly
> around your changes to incluce/FLAC/ordinals.h. This file is a
> public header file and hence, your changes:

Sorry about that, forgot that it is a public header.

[...]
> rely on "config.h" which is only available when FLAC is compiled, 
> not when this file is installed in /usr/include/FLAC or whereever.
> 
> I'll accept the rest of the patch. For the problem of this file, I
> think the best solution is to just remove all the CPP hackery and
> assume that a C99 <stdint.h> is available. THis would then make it
> incumbent on any developer that includes (either directly or
> indirectly) include/FLAC/ordinals.h to include some version of
> <stdint.h> first, even if it is just a mininal one with typedefs
> for the minimal set of sized ints.
> 
> Does that make sense?
> 

Yes that makes sense. Requiring a C99 compliant compiler seems quite
reasonable.
Dave

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (OS/2)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBTzNshnoc36Ns6m33AQKt5Af7BnGpopuXhyPJEYHc6NgYMMM8F6VzEtFa
MREYy7gT0hw/2jGzQ2BV0bAJk3xvTUrgXt79l9/WDCbudkSLiarAZXHMGI8gi0nJ
qfxEih7bzSO5SkTK+NRAtxFQFUXW+pqKigQZgjnw7zFCPO+gNCBR0Lx8OHEnn258
QmbGxTqxAboo1gRCmolJr2y2oa3be/fqMDKKysCOA6g+DFzQiCyBwjM/Pc+rI1bA
mrQ7exyXv8yDTsXlQrOsYpG8plzMxb3DaiWys6ugXB0OAMEUt6ncZh88qO7ccYQ8
v7JsdmBPsadG2jKbIgJiRca9qLdKbHrfF33clfj7tADMdTdayle+lQ==
=02lV
-----END PGP SIGNATURE-----