[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Feb 3 17:58:41 PST 2012


Earl Chew wrote:

> Erik,
> 
> My working view has this as the last commit:
> 
> commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16
> Author: David Schleef <ds at schleef.org>
> Date:   Thu Aug 25 18:40:29 2011 -0700
> 
>     Fix md5 structure clearing in previous commit
> 
> 
> 
> Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.

<snip>

> Do you have any more insight ?

Ok, using a bit of git bisect magic, I find that if your cuesheet patch
had been applied on top of commit 19e3918d4e, then this patch:

    commit ce8a75134cace056f6c436d54b57bad1a1d93797
    Author: Erik de Castro Lopo <erikd at mega-nerd.com>
    Date:   Wed Feb 1 20:34:04 2012 +1100

        Fix a bunch of printf format warnings.

Broke it again.

I'll work on this some more.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list