[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion

Earl Chew earl_chew at yahoo.com
Thu Feb 2 08:50:17 PST 2012


Erik,

I'll resync and have another look.

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Wednesday, February 1, 2012 10:30:21 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
 
Earl Chew wrote:

> When reading the INDEX from the cue sheet, the format MM:SS:FF format
> is disallowed if the sample frequency is not a multiple of 75 because
> the index would only be approximate. However, 00:00:00 is _exact_ because
> it denotes the start of the track, so allow it as a special case. This
> allows metaflac_test.sh to pass.

Thanks for this patch Earl, but unfortunately even with this patch in
place (and the exit 0 I added the script removed), test_metaflac.sh still
fails with:

     test case43: --import-cuesheet-from... ERROR: metadata does not match
     expected metaflac-test-files/case43-expect.meta

Would be great if you could have another look at this.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120202/e35c9258/attachment.htm 


More information about the flac-dev mailing list