[flac-dev] [Flac-dev] pkg-config output and <FLAC/assert.h>

Erik de Castro Lopo mle+la at mega-nerd.com
Wed Apr 25 18:22:15 PDT 2012


Erik de Castro Lopo wrote:

> The problem is that currently the pkg-config shipped with most distros
> (ie from the last release) gives this:
> 
>     $ pkg-config --cflags flac
>     -I/usr/include/FLAC 
> 
> This encourages people in client code to do:
> 
>     #include <all.h>
> 
> which obviously has the potential to cause problems.
> 
> Instead pkg-config should give:
> 
>     $ pkg-config --cflags flac
>     -I/usr/include/FLAC 
> 
> so that client code can do:
> 
>     #include <FLAC/all.h>
> 
> I'll submit a patch to fix this.


Actually, thats already been fixed in Git:

commit 7ae181f27c16e7eca45840ec9171b938b9f86fbc
Author: Josh Coalson <jcoalson at users.sourceforce.net>
Date:   Sat Nov 29 20:56:09 2008 +0000

    remove /FLAC++ suffix on include path

commit b76d4f817c54c6fcfcb82fe72e38660c1b480774
Author: Josh Coalson <jcoalson at users.sourceforce.net>
Date:   Sat Nov 29 20:55:52 2008 +0000

    remove /FLAC suffix on include path


Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list