[Flac-dev] Re: 1.2.0: Test suite failures on LP64 archs?

[Christian Weisgerber]

Christian Weisgerber <naddy at mips.inka.de> wrote:

> The bug was introduced in 1.2.0 with the fully unrolled functions
> in libFLAC/lpc.c.

I guess the use of unsigned index variables was an accident.  Changing
them back to int makes FLAC pass the "thorough" test suite on amd64.

--- src/libFLAC/lpc.c.orig	Sun Sep  2 00:13:36 2007
+++ src/libFLAC/lpc.c	Sun Sep  2 00:14:01 2007
@@ -569,7 +569,7 @@ void FLAC__lpc_compute_residual_from_qlp_coefficients_
 }
 #else /* fully unrolled version for normal use */
 {
-	unsigned i;
+	int i;
 	FLAC__int64 sum;
 
 	FLAC__ASSERT(order > 0);
@@ -1099,7 +1099,7 @@ void FLAC__lpc_restore_signal_wide(const FLAC__int32 r
 }
 #else /* fully unrolled version for normal use */
 {
-	unsigned i;
+	int i;
 	FLAC__int64 sum;
 
 	FLAC__ASSERT(order > 0);
-- 
Christian "naddy" Weisgerber                          naddy at mips.inka.de