[Flac-dev] Patch : Fix includes

Erik de Castro Lopo erikd-flac at mega-nerd.com
Mon Apr 16 03:36:03 PDT 2007


Hi all,

Below is a patch that fixes a couple of instances where a function
is used before it has been prototyped.

There was a little subtlty involved here because the file
include/test_libs_common/metadata_utils.h had the #include guard
the same as that of /src/test_libFLAC/metadata.h meaning that
only the first one included would actually do anthing.

Patch below.

Cheers,
Erik

diff -u -r1.4 metadata_utils.h
--- include/test_libs_common/metadata_utils.h	2 Feb 2007 06:58:21 -0000	1.4
+++ include/test_libs_common/metadata_utils.h	16 Apr 2007 10:23:37 -0000
@@ -16,8 +16,8 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  */
 
-#ifndef FLAC__TEST_LIBFLAC_METADATA_H
-#define FLAC__TEST_LIBFLAC_METADATA_H
+#ifndef FLAC__TEST_LIBFLAC_METADATA_UTILS_H
+#define FLAC__TEST_LIBFLAC_METADATA_UTILS_H
 
 /*
  * These are not tests, just utility functions used by the metadata tests
diff -u -r1.7 metadata.h
--- src/test_libFLAC/metadata.h	2 Feb 2007 06:58:24 -0000	1.7
+++ src/test_libFLAC/metadata.h	16 Apr 2007 10:24:34 -0000
@@ -22,5 +22,7 @@
 #include "FLAC/ordinals.h"
 
 FLAC__bool test_metadata(void);
+FLAC__bool test_metadata_file_manipulation(void);
+FLAC__bool test_metadata_object(void) ;
 
 #endif
diff -u -r1.25 metadata_object.c
--- src/test_libFLAC/metadata_object.c	2 Feb 2007 06:58:24 -0000	1.25
+++ src/test_libFLAC/metadata_object.c	16 Apr 2007 10:24:38 -0000
@@ -23,6 +23,7 @@
 #include "FLAC/assert.h"
 #include "FLAC/metadata.h"
 #include "test_libs_common/metadata_utils.h"
+#include "metadata.h"
 #include <stdio.h>
 #include <stdlib.h> /* for malloc() */
 #include <string.h> /* for memcmp() */



-- 
+-----------------------------------------------------------+
  Erik de Castro Lopo
+-----------------------------------------------------------+
"The fury with which untenable beliefs are defended is inversely
proportional to their defensibility."
-- Richard Dawkins


More information about the Flac-dev mailing list