[PATCH] Re: [Flac-dev] Strangeness with OggFlac files
giles at xiph.org
Mon Nov 6 11:56:47 PST 2006
On Tue, Nov 07, 2006 at 06:31:04AM +1100, Erik de Castro Lopo wrote:
> I haven't tested it, but I don't think just setting packet.e_o_s
> is sufficient to close the stream. The forced ogg_stream_flush()
> is required.
libogg checks the e_o_s flag (and has always done so, according to svn)
so you shouldn't have to call ogg_stream_flush() except when you want to
force a page boundary (such as after the header packets).
ogg/src/framing.c line 449
One common mistake it to not loop on ogg_stream_pageout() but it looks
like ogg_encoder_aspect.c is doing that.
More information about the Flac-dev