[PATCH] Re: [Flac-dev] Strangeness with OggFlac files

[Josh Coalson]

--- Erik de Castro Lopo <erikd-flac at mega-nerd.com> wrote:
> Erik de Castro Lopo wrote:
> 
> > Josh et al,
> > 
> > I've been tracking down a problem with generating OggFlac files.
> 
> <snip>
> 
> > I have looked into this and suspect that the
> FLAC__stream_encoder_finish()
> > function needs to finish off the stream using a call to
> ogg_stream_flush()
> > instead of the standard function ogg_stream_pageout().
> 
> I bashed on this a bit further and came up with the following patch:
> 
>     http://www.mega-nerd.com/tmp/flac-end_of_stream.diff
> 
> There's probably a more tasteful way of acheiving the same result,
> but
> this version does fix the problem.

thanks Erik, can you confirm that this is happening only because
the total_samples_estimate is 0?  (so the e_o_s setting in the
existing code is never triggered).

Josh




 
____________________________________________________________________________________
Sponsored Link

Degrees online in as fast as 1 Yr - MBA, Bachelor's, Master's, Associate
Click now to apply http://yahoo.degrees.info