[Flac-dev] A couple of points about flac 1.1.1 on ppc/linux/altivec

[John Steele Scott]

Josh Coalson <xflac at yahoo.com> writes:

> --- John Steele Scott <toojays at toojays.net> wrote:
>> Back in October 2004, I did a bit of work on FLAC to get version
>> 1.1.1 to
>> build correctly under GNU/Linux/PPC. Only now have I realised that
>> somewhere
>> along the way something broke in FLAC's decoding. On my machine,
>> roughly 50%
>> of FLAC files are being decoded incorrectly.
>> 
>> I presume that I broke the code somehow when translating Josh's
>> original OS X
>> assembler into GNU style.
>
> are you the one who submitted the patch with a translated
> version of lpc_asm.s?  I thought that was Luca.

I'm not sure exactly what happened. What you have in CVS:
<http://cvs.sourceforge.net/viewcvs.py/flac/flac/src/libFLAC/ppc/gas/lpc_asm.s?rev=1.1&view=log>

is not the same as the patch applied by Gentoo:
<http://www.gentoo.org/cgi-bin/viewcvs.cgi/media-libs/flac/files/flac-1.1.1-altivec.patch.gz>

There is little difference between either version except for the comment
style, and the way constant addresses are specified. Also the Gentoo patch
patches cpu.c, otherwise the Altivec code path isn't taken.

I'm trying to get a handle on where I should be looking to fix the problem. If
your saying that the gas version in FLAC CVS has been validated, the easiest
solution is to just use that one. Otherwise I need to go back to the Apple
version. Presumably that one has been thouroughly checked?

cheers,

John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 282 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20050121/6dae74f7/attachment.pgp