[Flac-dev] OS X compile errors

[Ben Hines]

On Thursday, January 9, 2003, at 11:38  AM, Ben Hines wrote:

>
> On Tuesday, January 7, 2003, at 07:54  PM, Glenn wrote:
>
>>
>> I've got xmms installed (via fink) and I'd really like to get the 
>> xmms-flac plugin to work.
>>
>> Suggestions?
>>
>
> You could of course use the FLAC from fink, it comes with the plugin. 
> I haven't updated it for 1.0.4 (because the library paths were messed 
> up, causing the build to fail) and not to 1.0.5 because it isn't out 
> yet.
>
> Hopefully the library bug will be fixed in 1.0.5, perhaps i should try 
> it before you release. :)
>

Nope, it still fails:

gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I/sw/include -I../.. -I./include 
-I../../include -I/sw/include -O3 -DNDEBUG -fomit-frame-pointer 
-funroll-loops -finline-functions -Wall -W -Winline 
-DFLaC__INLINE=__inline__ -c file_decoder.c 
-Wp,-MD,.deps/file_decoder.TPlo  -fno-common -DPIC -o 
.libs/file_decoder.lo
../../include/FLAC/format.h:144: syntax error, missing `;' after `const'
../../include/FLAC/format.h:147: syntax error, missing `;' after `const'
../../include/FLAC/format.h:152: syntax error, missing `;' after `const'

It looks like this time, it is due to my CPPFLAGS setting:


CPPFLAGS = -I/sw/include
DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
CFLAGS = -I$(top_builddir) -I$(srcdir)/include -I$(top_srcdir)/include 
-I/sw/include -O3 -DNDEBUG -fomit-frame-pointer -funroll-loops 
-finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__
COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
	$(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)


All of those "-I$(top_builddir) -I$(srcdir)/include 
-I$(top_srcdir)/include" are getting put after the -I/sw/include which 
breaks things.

It looks like this CPPFLAGS is being added by your configure script 
from the dlopen check:
     AC_REQUIRE([_LT_AC_CHECK_DLFCN])dnl
     test "x$ac_cv_header_dlfcn_h" = xyes && CPPFLAGS="$CPPFLAGS 
-DHAVE_DLFCN_H"

But its still a bug in your buildsystem, all your local include paths 
should always be before user specified ones, CPPFLAGS or CFLAGS.

-Ben