[Flac-dev] patches for flac build

[Matt Zimmerman]

On Mon, Jul 09, 2001 at 11:26:56AM -0700, collver at linuxfreemail.com wrote:

> libtool would not link the "plain" nasm-generated object files for the i386
> assembly optimizations.  I've patched src/libFLAC/i386/Makefile.am to operate
> similarly to the automake file used for the SDL assembly routines.
>
> I saw a post to the FLAC mailing list saying that automake expects the suffix
> to be .s, so .nasm files were renamed to .s files.  automake can be told to
> accept other suffixes using the SUFFIXES variable.  libtool recognizes files
> with .asm suffixes, so I renamed .s files to .asm files.

Unfortunately, there is a bigger problem that affects both SDL and FLAC, which
is that the assembly routines are not PIC.  This is already causing problems
for SDL on ia64 for Debian, where gcc refuses to link non-PIC code into a
shared library.

Either the assembly code must be made position-independent, or it must be
excluded from the shared library somehow.

> The first two patches cause libtool to generate the object files for the
> i386 assembly optimizations.  The third patch fixes a linking bug for the
> xmms plugin.  (does the xmms plugin link out-of-the-box on other platforms?)

That is a bug; in fact, the correct thing is to specify the path to the .la
file, and not use -l at all.  This is fixed in current CVS.

-- 
 - mdz