[xiph-commits] r19089 - trunk/vorbis-tools/share

giles at svn.xiph.org giles at svn.xiph.org
Fri Feb 14 13:09:52 PST 2014


Author: giles
Date: 2014-02-14 13:09:51 -0800 (Fri, 14 Feb 2014)
New Revision: 19089

Modified:
   trunk/vorbis-tools/share/charset.c
Log:
Fix typo in conditional.

Typo in the conditional to check the exit condition in ascii_strcasecmp.
It checks for (!*s1 || !*s1) instead of (!*s1 || !*s2). The typo did
not affect the result of the function as the loop is exited before
changing s1 or s2 anyway.

Fix ported from the copy in the flac library. Thanks to dcb314 for
reporting it here.

Closes https://trac.xiph.org/ticket/2007


Modified: trunk/vorbis-tools/share/charset.c
===================================================================
--- trunk/vorbis-tools/share/charset.c	2014-02-11 18:55:07 UTC (rev 19088)
+++ trunk/vorbis-tools/share/charset.c	2014-02-14 21:09:51 UTC (rev 19089)
@@ -55,7 +55,7 @@
   char c1, c2;
 
   for (;; s1++, s2++) {
-    if (!*s1 || !*s1)
+    if (!*s1 || !*s2)
       break;
     if (*s1 == *s2)
       continue;



More information about the commits mailing list