[xiph-commits] r17951 - in trunk/theora: . include/theora symbian

[giles at svn.xiph.org]

Author: giles
Date: 2011-05-03 12:54:02 -0700 (Tue, 03 May 2011)
New Revision: 17951

Modified:
   trunk/theora/configure.ac
   trunk/theora/include/theora/theora.h
   trunk/theora/symbian/config.h
Log:
Remove the --disable-float configure option, and the corresponding
THEORA_DISABLE_FLOAT C preprocessor symbol.

This originally disabled slow floating point code in the library,
but the critical path code has all been removed. It also used
to disable function of th_granule_time() which returns a double,
but it has not done so since prior to the 1.0 release, and there
have been no complaints.

It might be helpful to restore this option if it eliminated    
the th_granule_time() API entry entirely, so that platforms
without native floating point don't have to link to an emulation
library, but in the absence of a request we prefer shorter code.


Modified: trunk/theora/configure.ac
===================================================================
--- trunk/theora/configure.ac	2011-05-03 19:32:50 UTC (rev 17950)
+++ trunk/theora/configure.ac	2011-05-03 19:54:02 UTC (rev 17951)
@@ -506,19 +506,6 @@
 dnl Overall build configuration options
 dnl --------------------------------------------------
 
-dnl Configuration option for building of floating point code.
-
-ac_enable_float=yes
-AC_ARG_ENABLE(float,
-     AS_HELP_STRING([--disable-float], [Disable use of floating point code]),
-     [ ac_enable_float=$enableval ], [ ac_enable_float=yes] )
-
-if test "x${ac_enable_float}" != xyes ; then
-    AC_DEFINE([THEORA_DISABLE_FLOAT], [], 
-  [Define to exclude floating point code from the build])
-fi
-AM_CONDITIONAL(THEORA_DISABLE_FLOAT, [test "x${ac_enable_float}" != xyes])
-
 dnl Configuration option for building of encoding support.
 
 ac_enable_encode=yes
@@ -630,7 +617,6 @@
   General configuration:
 
     Encoding support: ........... ${ac_enable_encode}
-    Floating point support: ..... ${ac_enable_float}
     Assembly optimization: ...... ${cpu_optimization}
     Debugging telemetry: ........ ${ac_enable_telemetry}
     Build example code: ......... ${ac_enable_examples}

Modified: trunk/theora/include/theora/theora.h
===================================================================
--- trunk/theora/include/theora/theora.h	2011-05-03 19:32:50 UTC (rev 17950)
+++ trunk/theora/include/theora/theora.h	2011-05-03 19:54:02 UTC (rev 17951)
@@ -670,9 +670,7 @@
  *          This is the "end time" for the frame, or the latest time it should
  *           be displayed.
  *          It is not the presentation time.
- * \retval -1. The given granulepos is undefined (i.e. negative), or
- * \retval -1. The function has been disabled because floating
- *              point support is not available.
+ * \retval -1. The given granulepos is undefined (i.e. negative).
  */
 extern double theora_granule_time(theora_state *th,ogg_int64_t granulepos);
 

Modified: trunk/theora/symbian/config.h
===================================================================
--- trunk/theora/symbian/config.h	2011-05-03 19:32:50 UTC (rev 17950)
+++ trunk/theora/symbian/config.h	2011-05-03 19:54:02 UTC (rev 17951)
@@ -37,10 +37,6 @@
 
 #define THEORA_SUPPORT_ENCODE 0
 
-/* Do not build floating point code */
-
-#define	THEORA_DISABLE_FLOAT 1
-
 #ifdef __WINS__
 
 /* Disable some warnings */