[xiph-commits] r17505 - trunk/theora/lib

tterribe at svn.xiph.org tterribe at svn.xiph.org
Tue Oct 12 12:56:11 PDT 2010


Author: tterribe
Date: 2010-10-12 12:56:11 -0700 (Tue, 12 Oct 2010)
New Revision: 17505

Modified:
   trunk/theora/lib/state.c
Log:
Avoid harmless Coverity warning in oc_sb_create_plane_mapping().

Coverity thinks we're overrunning this static array by passing it to memset.
In reality, it's a multidimensional array, and guaranteed to be contiguous, but
 we might as well silence this warning.
Reported in https://bugzilla.mozilla.org/show_bug.cgi?id=559343


Modified: trunk/theora/lib/state.c
===================================================================
--- trunk/theora/lib/state.c	2010-10-12 18:59:45 UTC (rev 17504)
+++ trunk/theora/lib/state.c	2010-10-12 19:56:11 UTC (rev 17505)
@@ -159,7 +159,7 @@
       if(jmax>4)jmax=4;
       else if(jmax<=0)break;
       /*By default, set all fragment indices to -1.*/
-      memset(_sb_maps[sbi][0],0xFF,sizeof(_sb_maps[sbi]));
+      memset(_sb_maps[sbi],0xFF,sizeof(_sb_maps[sbi]));
       /*Fill in the fragment map for this super block.*/
       xfrag=yfrag+x;
       for(i=0;i<imax;i++){



More information about the commits mailing list